Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: selectedIndex property ignores disabled options #5910

Merged
merged 8 commits into from
May 2, 2022

Conversation

radium-v
Copy link
Collaborator

Pull Request

📖 Description

  • Changes the slottedOptionFilter to include disabled options.
  • Cleans up formatting in the value setter for the select component.

🎫 Issues

Fixes #4189.

📑 Test Plan

All tests should pass.

✅ Checklist

General

  • I have included a change request file using $ yarn change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

@ghost
Copy link

ghost commented Apr 28, 2022

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ radium-v sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@radium-v radium-v merged commit 9c36455 into master May 2, 2022
@radium-v radium-v deleted the users/jokreitl/select-include-disabled branch May 2, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

selectedIndex property ignores disabled options in listbox and select components
5 participants