Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSS typo in radio group stories #5632

Merged
merged 6 commits into from
Mar 8, 2022
Merged

Fix CSS typo in radio group stories #5632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ab6fad8
Fix CSS typo in radio group stories
fcollonval Feb 22, 2022
bdb7ac2
Change files
fcollonval Feb 22, 2022
b74a578
Merge branch 'master' into fix/radio-group-label-css-typo
janechu Feb 22, 2022
878b2c2
Merge branch 'master' into fix/radio-group-label-css-typo
janechu Feb 22, 2022
cbd0067
Merge branch 'master' into fix/radio-group-label-css-typo
chrisdholt Mar 8, 2022
a14c545
Merge branch 'master' into fix/radio-group-label-css-typo
chrisdholt Mar 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@microsoft-fast-components-31454069-d8f9-4011-9be1-184a33fa15a0.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "Fix CSS typo in radio group stories",
"packageName": "@microsoft/fast-components",
"email": "fcollonval@gmail.com",
"dependentChangeType": "none"
}
16 changes: 8 additions & 8 deletions packages/web-components/fast-components/src/radio-group/fixtures/base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ <h1>Radio Group</h1>
<h2>Defaults</h2>
<div>
<fast-radio-group name="numbers">
<label style="color: --var(neutral-foreground-rest);" slot="label">
<label style="color: var(--neutral-foreground-rest);" slot="label">
Numbers
</label>
<fast-radio value="one">One</fast-radio>
Expand All @@ -38,7 +38,7 @@ <h2>Defaults</h2>

<div>
<fast-radio-group id="vertical" orientation="vertical" name="trees">
<label style="color: --var(neutral-foreground-rest);" slot="label">
<label style="color: var(--neutral-foreground-rest);" slot="label">
Trees
</label>
<fast-radio id="fir" value="fir">Fir</fast-radio>
Expand All @@ -50,22 +50,22 @@ <h2>Defaults</h2>

<div style="display: flex; flex-direction: column; margin-top: 12px;">
<fast-radio-group name="players">
<label style="color: --var(neutral-foreground-rest);" slot="label">
<label style="color: var(--neutral-foreground-rest);" slot="label">
Best basketball players
</label>
<fast-radio value="airjordan">Michael Jordan</fast-radio>
</fast-radio-group>
</div>

<div style="display: flex; flex-direction: column; margin-top: 12px;">
<label style="color: --var(neutral-foreground-rest);">
<label style="color: var(--neutral-foreground-rest);">
Single radio (no group)
</label>
<fast-radio value="single-life">Single life</fast-radio>
</div>

<div style="display: flex; flex-direction: column; margin-top: 12px;">
<label style="color: --var(neutral-foreground-rest);" id="label1">
<label style="color: var(--neutral-foreground-rest);" id="label1">
Outside label
</label>
<fast-radio-group required="true" aria-labelledby="label1" name="fruits">
Expand Down Expand Up @@ -94,7 +94,7 @@ <h2>Defaults</h2>
</div>

<div style="display: flex; flex-direction: column; margin-top: 12px;">
<label style="color: --var(neutral-foreground-rest);" id="label2">
<label style="color: var(--neutral-foreground-rest);" id="label2">
Disabled radio group
</label>
<fast-radio-group disabled aria-labelledby="label2" name="cars">
Expand All @@ -104,7 +104,7 @@ <h2>Defaults</h2>
</div>

<div style="display: flex; flex-direction: column; margin-top: 12px;">
<label style="color: --var(neutral-foreground-rest);" id="label3">
<label style="color: var(--neutral-foreground-rest);" id="label3">
readonly radio group
</label>
<fast-radio-group readonly aria-labelledby="label3" name="office">
Expand All @@ -114,7 +114,7 @@ <h2>Defaults</h2>
</div>

<div style="display: flex; flex-direction: column; margin-top: 12px;">
<label style="color: --var(neutral-foreground-rest);" id="label4">
<label style="color: var(--neutral-foreground-rest);" id="label4">
Preset selected-value
</label>
<fast-radio-group value="maverick" aria-labelledby="label4" name="best-pilot">
Expand Down