Updated calculateOverlayColor to automatically determine the overlay color #5544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bheston
requested review from
chrisdholt,
EisenbergEffect,
janechu and
nicholasrice
as code owners
chrisdholt
approved these changes
Jan 26, 2022
EisenbergEffect
approved these changes
Jan 27, 2022
bheston
force-pushed
the
users/bheston/auto-overlay-color
branch
from
0236077 to
62866b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Calculating an overlay color is the base of the support for opacity in the color algorithms. This is from some of the proof of concept work and automatically determines if the overlay color should be white or black rather than requiring a color to be passed in.
🎫 Issues
👩💻 Reviewer Notes
📑 Test Plan
✅ Checklist
General
$ yarn change⏭ Next Steps
One fewer change in the way of adding support for opacity in the color system!