Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pr testing for documentation #5364

Merged
merged 6 commits into from
Nov 6, 2021
Merged

add pr testing for documentation #5364

merged 6 commits into from
Nov 6, 2021

Conversation

awentzel
Copy link
Collaborator

@awentzel awentzel commented Nov 4, 2021

Pull Request

📖 Description

Implements PR testing for documentation site.

  • Deploys to Azure Static Web Apps
  • Generates link to view the site embedded in PR comment
  • Redefines workflow with jobs running in parallel
  • Improves perf sharing between jobs with uploading/downloading artifacts so only have to build once

🎫 Issues

n/a, feature addition

👩‍💻 Reviewer Notes

This will require testing several key scenarios.

  1. only merges to master branch should fire documentation build and deployment to https://stage.www.fast.design
  2. only PR events should fire build and deployment to static web apps and that content will be destroyed on pr close.
  3. Verify outside contribtors
  4. Verify inside contributors
  5. Verify on merge to master

📑 Test Plan

✅ Checklist

General

  • I have included a change request file using $ yarn change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

⏭ Next Steps

Replicate this workflow change to other deployment sites.

@awentzel awentzel self-assigned this Nov 4, 2021
@awentzel awentzel added area:cloud area:dev-ops Pertains to build, CI, and other dev-ops work labels Nov 4, 2021
@awentzel awentzel force-pushed the users/awentzel/add-stapp branch from 32b47a9 to f6b1f71 Compare November 4, 2021 20:10
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

Azure Static Web Apps: Your stage site is ready! Visit it here: https://purple-ocean-0b7ce3410-5364.centralus.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

Azure Static Web Apps: Your stage site is ready! Visit it here: https://purple-ocean-0b7ce3410-5364.centralus.azurestaticapps.net

@awentzel awentzel changed the title add PR testing to documentation add pr testing for documentation Nov 4, 2021
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

Azure Static Web Apps: Your stage site is ready! Visit it here: https://purple-ocean-0b7ce3410-5364.centralus.azurestaticapps.net

@awentzel awentzel force-pushed the users/awentzel/add-stapp branch from f2162a3 to 1c7f07d Compare November 4, 2021 22:09
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

Azure Static Web Apps: Your stage site is ready! Visit it here: https://purple-ocean-0b7ce3410-5364.centralus.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Nov 6, 2021

Azure Static Web Apps: Your stage site is ready! Visit it here: https://purple-ocean-0b7ce3410-5364.centralus.azurestaticapps.net

@awentzel awentzel merged commit bfa5434 into master Nov 6, 2021
@awentzel awentzel deleted the users/awentzel/add-stapp branch November 6, 2021 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-ops Pertains to build, CI, and other dev-ops work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants