Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Disabling scroll easing for speed=0 #5239

Merged
merged 11 commits into from
Sep 30, 2021
Merged

fix: Disabling scroll easing for speed=0 #5239

merged 11 commits into from
Sep 30, 2021

Conversation

robarbms
Copy link
Contributor

Pull Request

📖 Description

Horizontal scroll tests are failing for Mac. This disables the smooth scrolling when the speed is set to 0.

🎫 Issues

👩‍💻 Reviewer Notes

📑 Test Plan

✅ Checklist

General

  • I have included a change request file using $ yarn change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

⏭ Next Steps

@robarbms robarbms merged commit 5646a82 into master Sep 30, 2021
@robarbms robarbms deleted the users/robarb/scroll-tests branch September 30, 2021 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eljefe223 eljefe223 eljefe223 approved these changes

@nicholasrice nicholasrice nicholasrice approved these changes

@EisenbergEffect EisenbergEffect EisenbergEffect approved these changes

@chrisdholt chrisdholt Awaiting requested review from chrisdholt

@janechu janechu Awaiting requested review from janechu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robarbms @EisenbergEffect @nicholasrice @eljefe223