fix: resolve an issue where linked data that cannot be dropped on was not allowed to drop #5175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not allowed to drop
janechu
requested review from
chrisdholt,
EisenbergEffect and
nicholasrice
as code owners
nicholasrice
approved these changes
Sep 9, 2021
williamw2
approved these changes
Sep 9, 2021
janechu
deleted the
users/janechu/fix-drag-and-drop-missing-linked-data-undroppables
branch
robarbms
pushed a commit
that referenced
this pull request
Sep 15, 2021
… not allowed to drop (#5175) # Pull Request ## 📖 Description <!--- Provide some background and a description of your work. What problem does this change solve? Is this a breaking change, chore, fix, feature, etc? --> This change adds the linked data type corresponding to linked data that typically includes elements such as `<img />` and `<input />` which do not contain content to a list of items that now allow it to be dropped. ## 👩💻 Reviewer Notes <!--- Provide some notes for reviewers to help them provide targeted feedback and testing. Do you recommend a smoke test for this PR? What steps should be followed? Are there particular areas of the code the reviewer should focus on? --> Build and run Creator application and add an `img` element, and another container element such as `div`, then attempt to drag the `img` into the `div`. This should now be possible. ## 📑 Test Plan <!--- Please provide a summary of the tests affected by this work and any unique strategies employed in testing the features/fixes. --> As part of the drag and drop core functionality, this is untestable in unit tests. ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [x] I have included a change request file using `$ yarn change` - [ ] I have added tests for my changes. - [x] I have tested my changes. - [ ] I have updated the project documentation to reflect my changes. - [x] I have read the [CONTRIBUTING](https://github.com/Microsoft/fast/blob/master/CONTRIBUTING.md) documentation and followed the [standards](https://www.fast.design/docs/community/code-of-conduct/#our-standards) for this project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
This change adds the linked data type corresponding to linked data that typically includes elements such as
<img />and<input />which do not contain content to a list of items that now allow it to be dropped.👩💻 Reviewer Notes
Build and run Creator application and add an
imgelement, and another container element such asdiv, then attempt to drag theimginto thediv. This should now be possible.📑 Test Plan
As part of the drag and drop core functionality, this is untestable in unit tests.
✅ Checklist
General
$ yarn change