Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: eslint fixes in fast-components #5005

Merged

Conversation

m4thieulavoie
Copy link
Collaborator

@m4thieulavoie m4thieulavoie commented Jul 28, 2021

Pull Request

πŸ“– Description

This PR fixes the eslint warnings in fast-components.

Before the changes

image

After the change

image

🎫 Issues

πŸ‘©β€πŸ’» Reviewer Notes

πŸ“‘ Test Plan

βœ… Checklist

General

  • I have included a change request file using $ yarn change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

⏭ Next Steps

@chrisdholt chrisdholt merged commit 46e4117 into microsoft:master Aug 10, 2021
@chrisdholt
Copy link
Member

Thanks @m4thieulavoie!

robarbms pushed a commit that referenced this pull request Sep 15, 2021
* chore: eslint fixes in fast-components

* Change files

Co-authored-by: Chris Holt <chhol@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants