Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update the exporting of services and web components in tooling and match the new pathing in sites #4961

Conversation

janechu
Copy link
Collaborator

@janechu janechu commented Jul 15, 2021

Pull Request

📖 Description

This change updates the export for @alpha web components and services from the @microsoft/fast-tooling package so they can be imported from the root location. It also corrects a few mis-typed const names that should be lowercase and it normalizes some file structures for easier exporting.

This change affects the Creator site and Explorer site as the pathing has been updated to reflect that these services and web components can now be imported from the root of the package.

Due to issues resulting from exporting web components from the root, jest test have been updated with mock files and the jest-environment-jsdom-sixteen package has been added to allow for more modern global methods assumed to be available in browsers.

👩‍💻 Reviewer Notes

It should not be necessary to run the sites as the build gate should break if the pathing is incorrect.

✅ Checklist

General

  • I have included a change request file using $ yarn change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@janechu janechu force-pushed the users/janechu/update-services-and-web-components-to-alpha-and-correct-pathing branch from 7bb7bdc to 58e97fe Compare July 16, 2021 17:49
@janechu janechu merged commit bc681d4 into master Jul 16, 2021
@janechu janechu deleted the users/janechu/update-services-and-web-components-to-alpha-and-correct-pathing branch July 16, 2021 18:17
@radium-v radium-v mentioned this pull request Jul 19, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants