feat(detail view): add detail view #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janechu
force-pushed
the
users/janechu/add-detail-to-dev-site
branch
from
aca195a to
387b9c7
Compare
nalogiudice
reviewed
May 23, 2018
| toggle_button: "toggle_button", | ||
| }, | ||
| children: "Toggle", | ||
| id: "toggle01", |
There was a problem hiding this comment.
Should id's be different in detailData vs data? You are using the same ids below
There was a problem hiding this comment.
This is elsewhere as well
There was a problem hiding this comment.
they don't need to be in this case since the views are never shown at the same time so the ids are always unique on the page
janechu
force-pushed
the
users/janechu/add-detail-to-dev-site
branch
from
4846466 to
97e38bb
Compare
janechu
force-pushed
the
users/janechu/add-detail-to-dev-site
branch
2 times, most recently
from
3078954 to
5a04a73
Compare
janechu
force-pushed
the
users/janechu/add-detail-to-dev-site
branch
2 times, most recently
from
e87f3dd to
828c2c2
Compare
janechu
force-pushed
the
users/janechu/add-detail-to-dev-site
branch
from
828c2c2 to
a87b769
Compare
janechu
force-pushed
the
users/janechu/add-detail-to-dev-site
branch
from
56e29d9 to
6566e73
Compare
nicholasrice
approved these changes
May 24, 2018
chrisdholt
reviewed
May 24, 2018
| ## Implementation example | ||
| ```javascript | ||
| ### Style guidance | ||
| Don't use *image* as a substitute for *hero*, *feature*, or *product* and *content placements*. Don't use an image if it reduces the effectiveness of the page. |
There was a problem hiding this comment.
FYI - created an issue #473 to scrub documentation for non-existent components. We'll handle this in a different PR.
chrisdholt
approved these changes
May 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #295