Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update contributing docs to include guidance for change files and feature branches #4630

Conversation

chrisdholt
Copy link
Member

Pull Request

📖 Description

This PR adds a note for how to include change files when working on feature branches.

✅ Checklist

General

  • I have included a change request file using $ yarn change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

@codeclimate
Copy link

codeclimate bot commented Apr 26, 2021

Code Climate has analyzed commit 03d78a4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 78.7% (0.0% change).

View more on Code Climate.

@EisenbergEffect EisenbergEffect merged commit 40b64c7 into master Apr 26, 2021
@EisenbergEffect EisenbergEffect deleted the users/chhol/update-docs-regarding-beachball-feature-branch branch April 26, 2021 15:33
scomea pushed a commit that referenced this pull request May 4, 2021
…ture branches (#4630)

Co-authored-by: Rob Eisenberg <EisenbergEffect@users.noreply.github.com>
scomea pushed a commit that referenced this pull request May 4, 2021
…ture branches (#4630)

Co-authored-by: Rob Eisenberg <EisenbergEffect@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants