Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: attempt to update server settings to allow for local testing of sites in iframes #4524

Conversation

janechu
Copy link
Collaborator

@janechu janechu commented Mar 31, 2021

Description

This allows sites to be referred to from a localhost environment.

Motivation & context

This should help with testing sites in iframes when used in localhost.

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@janechu janechu force-pushed the users/janechu/attempt-to-add-content-security-policy-for-frame-ancestors branch from e5c4798 to 59f84f2 Compare March 31, 2021 21:13
Copy link
Collaborator

@awentzel awentzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was previously set and found to be a security violation so I removed it. However, I didn't try setting a single attribute.

Rather, than let this PR go in and then have to revert, we can try this out on the creator staging site if you want? I can update directly on the server and then rescan, if it works great, we can let this change go in. If not, then we should find a secure solution.

@janechu
Copy link
Collaborator Author

janechu commented Mar 31, 2021

@awentzel that would be great!

@awentzel
Copy link
Collaborator

@awentzel that would be great!

Please try testing on https://stage.create.fast.design which now has your code implemented directly. Thanks

@codeclimate
Copy link

codeclimate bot commented Apr 1, 2021

Code Climate has analyzed commit e91ec82 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 85.2% (0.0% change).

View more on Code Climate.

@awentzel awentzel self-assigned this Apr 5, 2021
@awentzel awentzel added this to the Release 2021-04 milestone Apr 5, 2021
@awentzel
Copy link
Collaborator

Resolved by #4572 after manually testing.

@awentzel awentzel closed this Apr 10, 2021
@janechu janechu deleted the users/janechu/attempt-to-add-content-security-policy-for-frame-ancestors branch October 27, 2021 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants