Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update font to use cdn for security enhancement #4496

Merged
merged 2 commits into from
Mar 29, 2021

Conversation

awentzel
Copy link
Collaborator

Description

I've manually uploaded this font to https://static.fast.design/assets/fonts/SegoeUI-Roman-VF_web.ttf for access by the FAST Creator.

Motivation & context

Security requires not using third-party services.

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@williamw2
Copy link
Contributor

williamw2 commented Mar 25, 2021

The font path also appears in \fast\sites\site-utilities\src\components\editor\editor.style.css. Do we want to update that as well?

@awentzel awentzel changed the title chore: update font to use cdn chore: update font to use cdn for security enhancement Mar 29, 2021
@awentzel awentzel force-pushed the users/awentzel/update-font-cdn branch from bf8a042 to 5a6047a Compare March 29, 2021 16:56
@awentzel
Copy link
Collaborator Author

The font path also appears in \fast\sites\site-utilities\src\components\editor\editor.style.css. Do we want to update that as well?

Good Catch! Updated @williamw2

@codeclimate
Copy link

codeclimate bot commented Mar 29, 2021

Code Climate has analyzed commit 5a6047a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 85.2% (0.0% change).

View more on Code Climate.

@awentzel awentzel merged commit 68a1b4c into master Mar 29, 2021
@awentzel awentzel deleted the users/awentzel/update-font-cdn branch March 29, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants