Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add an inverse color recipe called neutral-contrast-fill #4319

Merged
merged 2 commits into from
Feb 3, 2021

Conversation

khamudom
Copy link
Contributor

@khamudom khamudom commented Feb 2, 2021

Description

Created a new fill recipe that would be inverted on a light or dark theme. This fill color would be dark on light theme and light on dark theme.
I also created neutralContrastForegroundRestBehavior a foreground behavior to use as a color with this recipe

Motivation & context

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@khamudom khamudom force-pushed the users/khamu/neutral-contrast-fill-recipe branch from e05ee39 to 69d6287 Compare February 3, 2021 00:12
@codeclimate
Copy link

codeclimate bot commented Feb 3, 2021

Code Climate has analyzed commit 69d6287 and detected 0 issues on this pull request.

View more on Code Climate.

@khamudom khamudom merged commit 403ec9a into master Feb 3, 2021
@khamudom khamudom deleted the users/khamu/neutral-contrast-fill-recipe branch February 3, 2021 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants