Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: hoist monaco-editor package #4299

Merged
merged 11 commits into from
Feb 3, 2021

Conversation

nicholasrice
Copy link
Contributor

@nicholasrice nicholasrice commented Feb 2, 2021

Description

Removes monaco-editor from the no-hoist yarn config. monaco-editor comes in at ~70mb and was getting installed by 4 separate packages. Hoisting monaco-editor will reduce the yarn install payload and speed up the install .

Motivation & context

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Copy link
Contributor

@EisenbergEffect EisenbergEffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Let's get an explicit approval from @janechu on this as well.

package.json Outdated Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Feb 3, 2021

Code Climate has analyzed commit ad8c08f and detected 0 issues on this pull request.

View more on Code Climate.

@nicholasrice nicholasrice merged commit 00805e6 into master Feb 3, 2021
@nicholasrice nicholasrice deleted the users/nirice/no-hoist-monaco-editor branch February 3, 2021 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants