Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolved socket.io #4291

Merged
merged 2 commits into from
Jan 30, 2021

Conversation

Ibrahimmaga
Copy link
Contributor

@Ibrahimmaga Ibrahimmaga commented Jan 29, 2021

Description

This is to fix dependabot moderate alerts for security and vulnerability (@socket.io and @node-notifier)

Motivation & context

To fix security and vulnerability in the software while resolving its dependencies.

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@EisenbergEffect
Copy link
Contributor

@Ibrahimmaga It is extremely important to include a description and a bit more context in your PR. Please add that here and make sure to include it in all issues and PRs going forward. This is an important part of our community process 😄

@Ibrahimmaga Ibrahimmaga merged commit 933f888 into users/imaga/Dependabot-Alerts-Moderate Jan 30, 2021
@Ibrahimmaga Ibrahimmaga deleted the Dependencies branch January 30, 2021 02:03
@Ibrahimmaga
Copy link
Contributor Author

Since this is a branch that can't be merge to master directly, I thought I will be be okay to skip the description. I just want the build to succeed then I will have a PR for Master. But it is a good practice for good documentation. I will work more on this.

Ibrahimmaga added a commit that referenced this pull request Feb 1, 2021
* fix: Resolved socket.io

* fix: Resolved node-notifier

Co-authored-by: Ibrahimmaga <ibrahim.maga@yahoo.fr>

Co-authored-by: Ibrahimmaga <ibrahim.maga@yahoo.fr>
Co-authored-by: Nicholas Rice <3213292+nicholasrice@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants