Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(features/playwright-integration): add harness script and configs for ts, mocha, rollup #4229

Conversation

radium-v
Copy link
Collaborator

@radium-v radium-v commented Jan 6, 2021

Description

  • add override configs to the fast-components/test directory to allow for a node-focused environment
  • spawn an express server before running mocha tests and stop it after completing all tests

New package.json commands in fast-components:

  • yarn clean:test: clean the test/dist directory
  • yarn test:build-tsc: build spec modules for mocha, outputs to test/dist
  • yarn test:build-rollup: build un-minimized and source-mapped bundles, to be loaded in the playwright browser page instance
  • yarn test:mocha: run all tests found in test/dist with the test/.mocharc.json configuration file
  • yarn test:playwright: run each command above, in order

To avoid conflicts with tests that already exist in src/color, the test:playwright workflow ignores those files, and the select.spec tests are skipped if playwright isn't available. Though it's not technically a blocker with this in place, these conflicts between task runners should be addressed before this completed feature is accepted.

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@radium-v radium-v merged commit fc05f7b into features/playwright-integration Jan 7, 2021
@radium-v radium-v deleted the users/jokreitl/playwright-integration branch January 7, 2021 17:35
@radium-v radium-v restored the users/jokreitl/playwright-integration branch January 7, 2021 17:35
@radium-v radium-v deleted the users/jokreitl/playwright-integration branch January 7, 2021 18:30
Ibrahimmaga added a commit that referenced this pull request Feb 18, 2021
* add playwright harness script and configs (#4229)

* split harness and server

* add environment variables
* fix tsconfig conflicts
* add README

* update yarn.lock after rebase

* install playwright latest

* Replace rollup-plugin-copy with copyfiles

* cross-env environment var setting

* add playwright CI

* add ci-workflow to linux machine

* add playwright ci to linux environment

* work flow fixes in linux

* resolve conflict issue

* playwright worflow

* playwright workflow

* fix run workflow

* install playwright for servers

* change tittle for the build

* Update .github/workflows/ci-weekly.yml

Co-authored-by: Jane Chu <7559015+janechu@users.noreply.github.com>

* Update build/copy.js

Co-authored-by: Jane Chu <7559015+janechu@users.noreply.github.com>

* remove blank lines

* renaming test dir to __test__

* organize gitignore files

* Update packages/web-components/fast-components/__test__/README.md

* fix environment variable casing

* remove abbreviation from environment variable

* sort package.json scripts

Co-authored-by: John Kreitlow <863023+radium-v@users.noreply.github.com>
Co-authored-by: John Kreitlow <john.kreitlow@microsoft.com>
Co-authored-by: nicholasrice <nicholasrice@users.noreply.github.com>
Co-authored-by: Ibrahim Maga <imaga75@hotmail.com>
Co-authored-by: Jane Chu <7559015+janechu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant