Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: slider disabled and readonly cursor styles #4224

Merged
merged 2 commits into from
Jan 14, 2021

Conversation

SethDonohue
Copy link
Contributor

@SethDonohue SethDonohue commented Jan 5, 2021

Description

Closes #4222

Note: There is no .slider class on this component's template, so the css .slider selector was not targeting anything. The disabled cursor still works on the labels and the forcedColors cursor style can be removed with this change as well.

Before:
Screen Shot 2021-01-05 at 11 35 39 AM

After:
Screen Shot 2021-01-05 at 11 34 24 AM

High Contrast:
Screen Shot 2021-01-05 at 1 31 05 PM

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Copy link
Contributor

@EisenbergEffect EisenbergEffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We recently did some changes in other components to move away from being based on host classes and instead leverage attribute selectors, as that's less invasive and less likely to conflict with frameworks that may be interacting with our components. Would it be possible to take that same approach in this case as well?

@SethDonohue SethDonohue force-pushed the users/v-sedono/fix-slider-disabled-cursor branch from cedf999 to e5edf92 Compare January 7, 2021 20:38
@SethDonohue
Copy link
Contributor Author

We recently did some changes in other components to move away from being based on host classes and instead leverage attribute selectors, as that's less invasive and less likely to conflict with frameworks that may be interacting with our components. Would it be possible to take that same approach in this case as well?

Updated to use attributes instead of classes. Will do so on anything in the future!

Copy link
Contributor

@marjonlynch marjonlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smoked, looks good

@SethDonohue SethDonohue force-pushed the users/v-sedono/fix-slider-disabled-cursor branch from e5edf92 to ac4c015 Compare January 12, 2021 23:46
@SethDonohue SethDonohue force-pushed the users/v-sedono/fix-slider-disabled-cursor branch from ac4c015 to 344211c Compare January 14, 2021 18:25
@SethDonohue SethDonohue merged commit 554760e into master Jan 14, 2021
@SethDonohue SethDonohue deleted the users/v-sedono/fix-slider-disabled-cursor branch January 14, 2021 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slider shows cursor pointer when disabled or readonly
4 participants