feat: add fast-number-field component for data applications #4204
Conversation
robarbms
requested review from
awentzel,
chrisdholt,
EisenbergEffect,
Falkicon,
janechu and
nicholasrice
as code owners
|
|
| required: false, | ||
| }, | ||
| ], | ||
| slots: [ |
There was a problem hiding this comment.
There are start and end slots as well yes?
There was a problem hiding this comment.
Added start and end slots.
packages/web-components/fast-foundation/src/number-field/number-field.template.ts
Outdated
Show resolved
Hide resolved
| ?required="${x => x.required}" | ||
| size="${x => x.size}" | ||
| :value="${x => x.value}" | ||
| type="text" |
There was a problem hiding this comment.
@robarbms Are there any potential implications with having this be articulated as text semantically and via AT but having it behave strictly as a number?
There was a problem hiding this comment.
I used text type rather than number to avoid limitations of number. You can not use float values unless your steps are set to a float value(not 1.0, it needs to be a fractional like 0.1). I do number validation on the component side rather than using the in built validation of type number.
There was a problem hiding this comment.
Thanks! Given that shift, I wonder if we should add support for inputmode as an attribute here with only numeric types? Research on that here for input with type text for numbers similar to the choice we're making: https://technology.blog.gov.uk/2020/02/24/why-the-gov-uk-design-system-team-changed-the-input-type-for-numbers/
There was a problem hiding this comment.
I've updated the inputmode. I left off pattern because I already had validation being handled on the valueChanged method using parseFloat. Their pattern seemed incomplete for data statistics and trying to maintain a pattern could be potentially problematic.
packages/web-components/fast-foundation/src/number-field/number-field.ts
Outdated
Show resolved
Hide resolved
…/robarb/number-field
…/robarb/number-field
…oft/fast into users/robarb/number-field
…/robarb/number-field
Description
Adds a fast-number-field component which takes numerical values that can be incremented and decremented in user defined stepped values.
Motivation & context
Provides a text entry for numerical values requested by community.
#3857
Issue type checklist
Is this a breaking change?
Adding or modifying component(s) in
@microsoft/fast-componentschecklistProcess & policy checklist