-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: formassociated and async tests on firefox #4158
Conversation
- make sure tests are async and clean up after themselves
Thanks for putting the work into this! Is there anything you think we can do to improve our test helpers to guide folks into the pit of success in the future? I'm hoping to pull the test helpers out into their own package for community use in the not distant future. We can certainly add docs around these things but I'm wondering if we can make the helpers better as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@EisenbergEffect I think documenting a scenario's cycle (setup, connect, test, disconnect) will be super useful, and making sure that components have general guidelines for what needs to be tested will go a long way for coverage. Just a few different types of tests I'm commonly seeing for our components are connection/disconnection, attributes, properties, user interaction, and form association. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome to see this!
Description
FormAssociated
tests on Firefoxselect
test that was incorrectly using native browser elementsMotivation & context
All of the
FormAssociated
tests were working in Chromium but failing in Firefox. There were also some tests that used timeouts and others that didn't utilize async fixture methods. Tests can use the fixture'sparent
anddocument
to attach elements like forms when needed, and all fixture-based tests should calldisconnect()
or remove any attached elements at the end of each scenario.Issue type checklist
Is this a breaking change?
Adding or modifying component(s) in
@microsoft/fast-components
checklistProcess & policy checklist