Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disabled menu items should be focusable #4154

Merged
merged 3 commits into from
Dec 3, 2020

Conversation

scomea
Copy link
Collaborator

@scomea scomea commented Nov 30, 2020

Description

The menu spec specifies that "disabled menu items are focusable but cannot be activated", but the implementation did not allow focus on disabled items. This changes the implementation to match the spec.

Motivation & context

  • noticed behavior did not match spec. Focusability allows discovery of disabled items for users of assistive technology.

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@scomea scomea merged commit b971a18 into master Dec 3, 2020
@scomea scomea deleted the users/scomea/menu-item-disabled-focus branch December 3, 2020 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants