Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add enter key handler to dictionary keys #4140

Merged
merged 2 commits into from
Nov 30, 2020

Conversation

williamw2
Copy link
Contributor

@williamw2 williamw2 commented Nov 20, 2020

Description

Adding a handler for the enter key in dictionary key fields that triggers a blur event instead of the default enter behavior.

Motivation & context

Fixes: #2287

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@williamw2 williamw2 merged commit bc0bb03 into master Nov 30, 2020
@williamw2 williamw2 deleted the user/williamw2/DictionaryEnterKey2287 branch November 30, 2020 18:06
@EisenbergEffect EisenbergEffect added this to the Release 2020-12 milestone Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Behavior for dictionaries should include enter on property keys
3 participants