Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove hover for disabled options #4130

Merged
merged 1 commit into from
Nov 19, 2020

Conversation

SethDonohue
Copy link
Contributor

Description

Motivation & context

This removes the hover effect for disabled option components as currently the hover affordance gives the perception that the option is still actionable.

Before:
Screen Shot 2020-11-18 at 3 34 13 PM

After:
Screen Shot 2020-11-18 at 3 33 25 PM

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@SethDonohue SethDonohue self-assigned this Nov 18, 2020
@SethDonohue SethDonohue force-pushed the users/v-sedono/fix-disabled-option-hover-visual branch from cba2c2c to b9ea630 Compare November 18, 2020 23:54
@SethDonohue SethDonohue force-pushed the users/v-sedono/fix-disabled-option-hover-visual branch 2 times, most recently from 7efef78 to 3965a36 Compare November 19, 2020 00:29
@SethDonohue SethDonohue force-pushed the users/v-sedono/fix-disabled-option-hover-visual branch from 3965a36 to 9d8719f Compare November 19, 2020 00:30
@SethDonohue SethDonohue changed the title fix: remove hover for aria-selected false options fix: remove hover for disabled options Nov 19, 2020
@EisenbergEffect EisenbergEffect self-requested a review November 19, 2020 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants