-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove hover for disabled options #4130
Merged
chrisdholt
merged 1 commit into
master
from
users/v-sedono/fix-disabled-option-hover-visual
Nov 19, 2020
Merged
fix: remove hover for disabled options #4130
chrisdholt
merged 1 commit into
master
from
users/v-sedono/fix-disabled-option-hover-visual
Nov 19, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SethDonohue
requested review from
chrisdholt,
EisenbergEffect,
janechu and
nicholasrice
as code owners
November 18, 2020 23:44
SethDonohue
force-pushed
the
users/v-sedono/fix-disabled-option-hover-visual
branch
from
November 18, 2020 23:54
cba2c2c
to
b9ea630
Compare
packages/web-components/fast-components/src/listbox-option/listbox-option.styles.ts
Outdated
Show resolved
Hide resolved
SethDonohue
force-pushed
the
users/v-sedono/fix-disabled-option-hover-visual
branch
2 times, most recently
from
November 19, 2020 00:29
7efef78
to
3965a36
Compare
SethDonohue
force-pushed
the
users/v-sedono/fix-disabled-option-hover-visual
branch
from
November 19, 2020 00:30
3965a36
to
9d8719f
Compare
SethDonohue
changed the title
fix: remove hover for aria-selected false options
fix: remove hover for disabled options
Nov 19, 2020
EisenbergEffect
approved these changes
Nov 19, 2020
chrisdholt
approved these changes
Nov 19, 2020
chrisdholt
deleted the
users/v-sedono/fix-disabled-option-hover-visual
branch
November 19, 2020 17:13
This was referenced Jan 13, 2022
This was referenced Mar 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation & context
This removes the hover effect for disabled option components as currently the hover affordance gives the perception that the option is still actionable.
Before:
After:
Issue type checklist
Is this a breaking change?
Adding or modifying component(s) in
@microsoft/fast-components
checklistProcess & policy checklist