Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixing breadcrumb spacing #4129

Merged
merged 2 commits into from
Nov 18, 2020

Conversation

williamw2
Copy link
Contributor

@williamw2 williamw2 commented Nov 18, 2020

Description

Updating breadcrumb spacing per design guidance. Reducing padding around breadcrumb separator from 8px to 4px.

I investigated replacing the custom breadcrumb markup in the form with the FASTComponent Breadcrumb controls, however, this would require refactoring that will be tackled as part of the larger effort to rebuild the fast-tooling-react package in web components.

Motivation & context

Fixes: #2043

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@williamw2 williamw2 merged commit 4106335 into master Nov 18, 2020
@williamw2 williamw2 deleted the user/williamw2/FixBreadcrumbSpacing2043 branch November 18, 2020 21:27
@EisenbergEffect EisenbergEffect added this to the Release 2020-12 milestone Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The spacing on breadcrumbs in Form should be updated per design guidance
4 participants