Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update generated css data to include more nesting solutions as well as new exports for property, syntax and types lists #4125

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

janechu
Copy link
Collaborator

@janechu janechu commented Nov 17, 2020

Description

This change:

  • Updates the syntax to be an object not an array (it would always resolve to a single array item)
  • Adds syntax, types and properties lists as type references
  • Updates nested groupings to be more precise and resolve more nesting situations (such as direct group nesting without any combinator splits)

Motivation & context

Further refines the data needed to complete #3773

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

…well as new exports for property, syntax and types lists
@janechu janechu merged commit b814aed into master Nov 17, 2020
@janechu janechu deleted the users/janechu/refine-mdn-custom-data branch November 17, 2020 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants