-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: convert FormAssociated to a constructable function #4115
Conversation
@nicholasrice there are still two tests that are breaking for me which were added recently, can you take a look and see if there's a quick fix? |
ca78bf0
to
3143cc7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this change. I made one request to move an interface. If we can make that change and get the tests all passing, I think we're good.
packages/web-components/fast-foundation/src/utilities/constructable.ts
Outdated
Show resolved
Hide resolved
I think the |
- Add Constructable utility type
3143cc7
to
ae62012
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @radium-v - this is awesome.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a lot of updates :)
Thanks @radium-v!
Description
Converts
FormAssociated
to be a "constructable" function call that returns a mixin class.Motivation & context
Allows for easier control when working with mixin classes and
FormAssociated
.Issue type checklist
Is this a breaking change?
Adding or modifying component(s) in
@microsoft/fast-components
checklistThis modifies all
FormAssociated
-based components:Button
Checkbox
Radio
Slider
Text Area
Text Field
I have added a new component
I have modified an existing component
I have updated the definition file
I have updated the configuration file
Process & policy checklist