Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flipper icon and menu item text in high contrast mode #4110

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

khamudom
Copy link
Contributor

@khamudom khamudom commented Nov 10, 2020

Description

Added color to the host selector in menu-item to fix high contrast white. Updated the high contrast selector in the flipper style to be set on a class instead of the attribute.

menu-item
before
image
after
image

flipper
before
image
image
image
image
after
image
image
image
image

Motivation & context

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@khamudom khamudom merged commit 69ec2cc into master Nov 10, 2020
@khamudom khamudom deleted the users/khamu/HC-flipper-menu-item branch November 10, 2020 17:17
@EisenbergEffect
Copy link
Contributor

I thought we were trying to base things off of attribute rather than class, for reasons of integration with React and such. Can someone clarify?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants