Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add operations scripts for maintaining infrastructure #4103

Merged
merged 76 commits into from
Nov 12, 2020

Conversation

awentzel
Copy link
Collaborator

@awentzel awentzel commented Nov 4, 2020

Description

This merges CLI work for managing the Azure infrastructure. These scripts perform operations for creating new services, destroying old services, and updating existing services. This is beta and mostly usable with some features yet to be implemented which are documented in comments and with GH issues.

This begins a FAST CLI extending the Azure CLI simplified maintainability with consistency, speed, and reliability.

Motivation & context

To provide an equal ability for all collaborators to perform common service needs. For example, perform release deployments of websites.

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@awentzel awentzel added chore Maintenance or non-code work area:dev-ops Pertains to build, CI, and other dev-ops work area:cloud labels Nov 4, 2020
@awentzel awentzel self-assigned this Nov 4, 2020
@awentzel awentzel requested a review from radium-v November 4, 2020 19:51
Copy link
Contributor

@EisenbergEffect EisenbergEffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment much on the scripts themselves. I haven't written bash scripts anywhere that complexity ;) Glad to see the documentation and get this in. Just want to also confirm that there's nothing in here that could be a security concern in terms of content, config, etc.

@nicholasrice
Copy link
Contributor

@awentzel please add the appropriate feat, fix, or chore flag to the title of this PR.

@awentzel awentzel changed the title add azure operations scripts for maintaining cloud infrastrastructure chore: add operations scripts for maintaining infrastructure Nov 9, 2020
build/operations/README.md Outdated Show resolved Hide resolved
build/operations/services/create-appi.sh Show resolved Hide resolved
build/operations/services/create-asp.sh Show resolved Hide resolved
awentzel and others added 2 commits November 12, 2020 12:16
Thanks Jane for the suggestion.

Co-authored-by: Jane Chu <7559015+janechu@users.noreply.github.com>
Copy link
Contributor

@marjonlynch marjonlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this is a multi-stage approach, I was able to get the scripts running and after selecting westus got a permissions error which was expected as I don't apparently have permissions for that.

@awentzel awentzel merged commit 3dba154 into master Nov 12, 2020
@awentzel awentzel deleted the users/awentzel/add-ops-scripts branch November 12, 2020 19:56
@EisenbergEffect EisenbergEffect linked an issue Nov 16, 2020 that may be closed by this pull request
@EisenbergEffect EisenbergEffect added this to the Release 2020-10 milestone Nov 16, 2020
@EisenbergEffect EisenbergEffect linked an issue Nov 16, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-ops Pertains to build, CI, and other dev-ops work chore Maintenance or non-code work
Projects
None yet
5 participants