Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated the background on attribute dropdown in fast tooling used in component explorer #4098

Merged
merged 3 commits into from
Nov 4, 2020

Conversation

khamudom
Copy link
Contributor

@khamudom khamudom commented Nov 4, 2020

Description

Created a new css property called FloatingCSSProperty with the color of #3b3b3b. This is applied to the option in the select input dropdown. This fixes the issue where the background in the dropdown blends into the background of the pane.

closes #3979

before
image
after
image

Motivation & context

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@khamudom khamudom force-pushed the users/khamu/select-dropdown-contrast branch from 38f394a to 4268e18 Compare November 4, 2020 06:10
@janechu
Copy link
Collaborator

janechu commented Nov 4, 2020

As an addition to our manual testing, can you add something to the CSSPropertyOverrides in app/pages/form.tsx around line 80?

Copy link
Contributor

@SethDonohue SethDonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for the vague name? Seems like it would be hard to decipher what it is used for.

@khamudom
Copy link
Contributor Author

khamudom commented Nov 4, 2020

Is there a reason for the vague name? Seems like it would be hard to decipher what it is used for.

It was suggested by Brian

@khamudom khamudom merged commit e6bd341 into master Nov 4, 2020
@khamudom khamudom deleted the users/khamu/select-dropdown-contrast branch November 4, 2020 18:36
@EisenbergEffect EisenbergEffect added this to the Release 2020-10 milestone Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: component explorer dropdowns need more differentiation from page background
6 participants