chore: update security for xss and http #3739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awentzel
added
area:dev-ops
awentzel
requested review from
chrisdholt,
EisenbergEffect,
Falkicon,
janechu and
nicholasrice
as code owners
nicholasrice
approved these changes
Aug 19, 2020
radium-v
requested changes
Aug 19, 2020
janechu
previously approved these changes
Aug 19, 2020
janechu
dismissed
their stale review
Saw some needed changes suggested by @radium-v
chrisdholt
approved these changes
Aug 19, 2020
EisenbergEffect
approved these changes
Aug 20, 2020
awentzel
force-pushed
the
users/awentzel/update-xss
branch
from
c6eaa6a to
4108abf
Compare
Co-authored-by: John Kreitlow <863023+radium-v@users.noreply.github.com>
Co-authored-by: John Kreitlow <863023+radium-v@users.noreply.github.com>
Co-authored-by: John Kreitlow <863023+radium-v@users.noreply.github.com>
Co-authored-by: John Kreitlow <863023+radium-v@users.noreply.github.com>
radium-v
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
X-XSS-Protectionto be removed as it provides a false sense of security and WebScout requires it to be removed. Additionally,httpreferences were found inside code. We should never link toHTTP. Always, reference theHTTPS.Motivation & context
WebScout discovered another batch of updates to make.
Issue type checklist
Is this a breaking change?
Adding or modifying component(s) in
@microsoft/fast-componentschecklistProcess & policy checklist