fix: changed setupDefault to set initialValue which will set dirtyValue fa… #3642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marjonlynch
requested review from
chrisdholt,
EisenbergEffect,
janechu and
nicholasrice
as code owners
EisenbergEffect
approved these changes
Aug 7, 2020
…lse after changing, fixed some typos in comments
marjonlynch
force-pushed
the
users/marjon/fix-slider-setupdefault
branch
from
3a6d21e to
c5f11e1
Compare
khamudom
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
setting initialValue in setupDefault which will set dirtyValue to false after changing and allow binding to update the value after.
closes #3635
Added to the fixtures a button to validate the change, each click attempts to increment the value of the slider.
Issue type checklist
Is this a breaking change?
Adding or modifying component(s) in
@microsoft/fast-componentschecklistProcess & policy checklist