-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(spec): add breadcrumb spec #3552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to dig into the implementation a bit more and understand the value of breadcrumb item
. Aside from being able to easily provide a separator within it, it seems to just wrap the anchor that would serve as the primary visual here. I'd like to see if we can simplify this API a bit.
@khamudom and I worked through a lot of options and there was definitely a difficulty in dealing with getting to right structure and incorporating the separator. It seems like the only way to get the separator is to have a wrapper element to render it because there's no way to wrap individual slotted elements. As I was reading the comments I did come up with a new idea though. Caveat: it's dependent on the new work in fast-element and the proposed new FoundationElement base class. With the new base class, all of our components would have a |
@EisenbergEffect I was rolling around something like that in my head but wasn’t sure how to reconcile with composability. I think that would be preferred here and a welcome addition. It’s worth waiting for that work in my opinion. |
There are a few more tricks to it since the child anchors would not be connected when the breadcrumbs connected callback fires. So, the child templates wouldn't be in place yet to wrap. I've got a couple of solutions in mind to it and will keep thinking about it a bit more. It might be worth introducing "template decorators" as an official concept for things like this and have some standard way of doing it. Need to think about it a bit more. |
Would css counter styles work for the separators? |
@radium-v I'm not sure. It probably depends on how flexible we want to make the separator. What if someone has a custom SVG, for example, do we want to support that or just a basic character? |
@EisenbergEffect my bad, I was thinking about |
Is it possible to apply a list style to something that isn't actually an li? If we give it an aria |
a1b4b0e
to
17795e7
Compare
Updated the fast-breadcrumb-item. instead of having an empty slot, added am anchor as a default control. This cleans up the html, it avoids having to add another control inside fast-breadcrumb-item. |
7eaa14e
to
2bffe69
Compare
0e9bc4d
to
d7f2c82
Compare
d7f2c82
to
c2b2d41
Compare
c2b2d41
to
51e120c
Compare
Description
The file has specs for
fast-breadcrumb
andfast-breadcrumb-item
Motivation & context
Issue type checklist
Is this a breaking change?
Adding or modifying component(s) in
@microsoft/fast-components
checklistProcess & policy checklist