Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct class name for text field start/end styles #3551

Merged
merged 6 commits into from
Jul 30, 2020

Conversation

chrisdholt
Copy link
Member

@chrisdholt chrisdholt commented Jul 24, 2020

Description

This PR fixes an unusual regression which I thought was already fixed. Fixing it again.

Motivation & context

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Copy link
Contributor

@EisenbergEffect EisenbergEffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember reviewing a PR like this too...maybe we fixed it in one design system but not the other?

@chrisdholt
Copy link
Member Author

I remember reviewing a PR like this too...maybe we fixed it in one design system but not the other?

Super odd - It's broken in both...I'm just not pushing a fix for MSFT because that package is about to drop in a subsequent PR :)

@EisenbergEffect EisenbergEffect merged commit d565dee into master Jul 30, 2020
@EisenbergEffect EisenbergEffect deleted the users/chhol/fix-start-end-content branch July 30, 2020 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants