-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add permutator that can permutate over the number type #3537
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approved with the caveat that I don't know C.
ba42efa
to
d45010b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The primary thing I'd like to see before merging is a bit more documentation. Two forms I'm thinking of: some code docs for each function and struct; some basic readme type info with build instructions and a high level explanation of the design/purpose.
a1a785a
to
5167620
Compare
5167620
to
0d72432
Compare
@EisenbergEffect I've already added build instructions in this projects CONTRIBUTING.md file, but I've added the other comments and more context to the README.md. |
Description
This kicks off the work to add the permutator, a utility written to provide permutations over JSON schema. This is the initial setup and iteration over the number type. Future additions include the types
string
,null
,boolean
,array
,object
andinteger
.Issue type checklist
Is this a breaking change?
Adding or modifying component(s) in
@microsoft/fast-components
checklistProcess & policy checklist