Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add permutator that can permutate over the number type #3537

Merged
merged 10 commits into from
Jul 23, 2020

Conversation

janechu
Copy link
Collaborator

@janechu janechu commented Jul 21, 2020

Description

This kicks off the work to add the permutator, a utility written to provide permutations over JSON schema. This is the initial setup and iteration over the number type. Future additions include the types string, null, boolean, array, object and integer.

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Copy link
Contributor

@nicholasrice nicholasrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approved with the caveat that I don't know C.

@janechu janechu force-pushed the users/janechu/add-permutator-in-c branch from ba42efa to d45010b Compare July 22, 2020 02:00
Copy link
Contributor

@EisenbergEffect EisenbergEffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The primary thing I'd like to see before merging is a bit more documentation. Two forms I'm thinking of: some code docs for each function and struct; some basic readme type info with build instructions and a high level explanation of the design/purpose.

@janechu janechu force-pushed the users/janechu/add-permutator-in-c branch 4 times, most recently from a1a785a to 5167620 Compare July 23, 2020 05:29
@janechu janechu force-pushed the users/janechu/add-permutator-in-c branch from 5167620 to 0d72432 Compare July 23, 2020 05:37
@janechu
Copy link
Collaborator Author

janechu commented Jul 23, 2020

@EisenbergEffect I've already added build instructions in this projects CONTRIBUTING.md file, but I've added the other comments and more context to the README.md.

@janechu janechu merged commit 74fad2d into master Jul 23, 2020
@janechu janechu deleted the users/janechu/add-permutator-in-c branch July 23, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants