feat: adds direction property to design system #3535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasrice
requested review from
chrisdholt,
EisenbergEffect and
janechu
as code owners
nicholasrice
force-pushed
the
users/nirice/add-direction-to-design-system
branch
from
1e28e8f to
84250d2
Compare
EisenbergEffect
approved these changes
Jul 21, 2020
|
@nicholasrice Do you happen to have a practical example of how this would be used in a component? That might be good to add to the PR description. |
scomea
approved these changes
Jul 21, 2020
|
@EisenbergEffect I'll add examples to the API docs |
janechu
approved these changes
Jul 21, 2020
chrisdholt
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds a
directionproperty to the design systems for FAST and MSFT to track the primary document direction. It also adds two behaviors to resolve CSS custom properties to direction-based values based on the design-systems direction. Ideally this wouldn't be necessary, but there are still significant gaps in browser support for https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Logical_Properties.Related to #3246. This addresses most of the issues in that thread but does not add the behavior to conditionally apply
ComposableStylesbased on direction. That piece is not blocking so taking as a follow-up.Motivation & context
Issue type checklist
Is this a breaking change?
Adding or modifying component(s) in
@microsoft/fast-componentschecklistProcess & policy checklist