fix: rollup minify selectors should retain spaces #3524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radium-v
requested review from
awentzel,
chrisdholt,
EisenbergEffect,
janechu and
nicholasrice
as code owners
radium-v
commented
Jul 17, 2020
| @@ -48,7 +48,7 @@ export const ProgressStyles = css` | |||
| height: 100%; | |||
| background-color: ${accentForegroundRestBehavior.var}; | |||
| border-radius: calc(var(--design-unit) * 1px); | |||
| animation-timing-function: cubic-bezier(0.4, 0.0, 0.6, 1.0); | |||
There was a problem hiding this comment.
These were likely automatically applied by vscode eslint.
| filesize({ showMinifiedSize: false }), | ||
| filesize({ | ||
| showMinifiedSize: false, | ||
| showBrotliSize: true, |
packages/web-components/fast-components-msft/src/slider/slider.styles.ts
Show resolved
Hide resolved
EisenbergEffect
approved these changes
Jul 17, 2020
chrisdholt
approved these changes
Jul 17, 2020
janechu
approved these changes
Jul 17, 2020
nicholasrice
approved these changes
Jul 20, 2020
radium-v
force-pushed
the
users/jokreitl/rollup-minify-fix
branch
from
16b3c45 to
b2ea909
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reduce complexity for CSS tagged template compression. Also spotted some invalid commas in the
progressstylesheets.Motivation & context
The CSS tagged template minifier was combining
:host() .childselectors, causing styles to not get rendered properly.Issue type checklist
Is this a breaking change?
Adding or modifying component(s) in
@microsoft/fast-componentschecklistProcess & policy checklist