Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: aspnet integration docs razor fixes #3503

Merged

Conversation

iantonge
Copy link
Contributor

Description

fix razor syntax in aspnet integration documentation

Motivation & context

There are a couple of minor mistakes in the razor syntax on the aspnet integrations documentation:

Copying the CDN link from the aspnet integration docs into a razor template causes a compilation error as the @ symbol needs to be escaped in razor.

Copying the fast-card sample code from the documentation renders a card where the title is the literal text 'ViewData["Title"]' rather than the value which should be 'Home Page'.

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@iantonge
Copy link
Contributor Author

I'm not entirely clear on the etiquette of creating a pull request, or if I should create an issue first. For a couple of small changes to the docs an issue might not be necessary, but I'm happy to take direction on that.

As an aside, the link to https://www.fast.design/docs/en/contributing/standards appears to just show me that same content as https://www.fast.design right now.

@EisenbergEffect
Copy link
Contributor

@iantonge This is perfect. Thank you! No need to create an issue for a doc fix like this. We'll get this reviewed and merged soon.

The contributor guide is here: https://www.fast.design/docs/community/contributor-guide Where did you find that old link? I'd like to get that fixed if you recall where you found it.

@iantonge
Copy link
Contributor Author

@EisenbergEffect the old link is in the "Process & policy checklist" section of the PR template.

@chrisdholt chrisdholt merged commit 1c28a3b into microsoft:master Jul 14, 2020
@iantonge iantonge deleted the asp-integration-docs-razor-fixes branch July 14, 2020 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants