feat: update sync logic to fire on node selection #3497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bheston
requested review from
EisenbergEffect,
janechu and
nicholasrice
as code owners
|
Going to pass on reviewing this since I'm not particularly familiar with this area of the codebase. What's the chance I could get a rundown on the Figma plugin sometime next week to bring me up to speed? |
|
@EisenbergEffect no worries. I could cover the "what" of the Figma plugin, but @nicholasrice or @Jeremy-Knudsen know the code better. |
packages/tooling/fast-figma-plugin-msft/src/figma/controller.ts
Outdated
Show resolved
Hide resolved
nicholasrice
approved these changes
Jul 10, 2020
bheston
force-pushed
the
users/bheston/figma-plugin-sync
branch
from
b1a98c3 to
7299c51
Compare
|
This PR is getting a little stale. @bheston Can you reach out to a few targeted individuals who you think can help with the review? |
bheston
force-pushed
the
users/bheston/figma-plugin-sync
branch
from
7299c51 to
7ccf8ac
Compare
janechu
approved these changes
Aug 4, 2020
bheston
force-pushed
the
users/bheston/figma-plugin-sync
branch
from
eeeada8 to
538b3f5
Compare
bheston
force-pushed
the
users/bheston/figma-plugin-sync
branch
from
538b3f5 to
d7abe54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated sync logic to fire on node selection. This will update a component when it's added or pasted into a new container.
Motivation & context
Currently you could have a themed design, but when adding a new theme-aware component it would not update to the theme settings. With this change it will update immediately when being placed into a themed container.
Issue type checklist
Is this a breaking change?
Adding or modifying component(s) in
@microsoft/fast-componentschecklistProcess & policy checklist