fix: wc menu keyboarding and aria-expanded #3496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scomea
requested review from
awentzel,
chrisdholt,
EisenbergEffect,
Falkicon,
janechu and
nicholasrice
as code owners
chrisdholt
reviewed
Jul 10, 2020
Comment on lines
+39
to
+40
| @attr({ attribute: "expanded" }) | ||
| public expanded: boolean; |
There was a problem hiding this comment.
This needs to be aria-expanded or AT will not recognize it as expanded. The attr should stay the same here. I think we you'll want is to keep the boolean attribute converter but change "reflect" to "fromView".
There was a problem hiding this comment.
We write to the "aria-expanded" attribute in the template, just like we do for disabled:
aria-expanded="${x => x.expanded}"
There was a problem hiding this comment.
If it's undefined we don't render a value, which fixes the bug
There was a problem hiding this comment.
gotcha, thanks for the additional context.
EisenbergEffect
approved these changes
Jul 10, 2020
chrisdholt
approved these changes
Jul 13, 2020
scomea
force-pushed
the
users/scomea/wc-menu-keys
branch
from
f66985f to
cbb26c0
Compare
added 6 commits
July 14, 2020 06:48
scomea
force-pushed
the
users/scomea/wc-menu-keys
branch
from
06d3991 to
970422e
Compare
nicholasrice
approved these changes
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A timing issue was causing the menu to check the role attribute of children to determine focusability before those children had a chance to update their roles. Waiting to check on the value change callback resolved that. Also, we were always setting an "aria-expanded" attribute on menu items which would cause menu items to announce as not expanded even when they had no expanded state to begin with.
Motivation & context
partially fixes #3481
Issue type checklist
Is this a breaking change?
Adding or modifying component(s) in
@microsoft/fast-componentschecklistProcess & policy checklist