Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct spelling of aria-labelledby in tabs #3463

Merged

Conversation

chrisdholt
Copy link
Member

@chrisdholt chrisdholt commented Jul 8, 2020

Description

Corrects the spelling of aria-labelledby in tabs. Currently the spelling renders the component inaccessible.

Motivation & context

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@chrisdholt chrisdholt self-assigned this Jul 8, 2020
@chrisdholt chrisdholt force-pushed the users/chhol/fix-all-incorrect-instances-of-labelledby branch from c365237 to 7ad847e Compare July 9, 2020 03:58
@chrisdholt chrisdholt merged commit c0385d9 into master Jul 9, 2020
@chrisdholt chrisdholt deleted the users/chhol/fix-all-incorrect-instances-of-labelledby branch July 9, 2020 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants