Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update typescript version and remove utility types dependencies for react packages #3422

Merged
merged 13 commits into from
Jul 3, 2020

Conversation

chrisdholt
Copy link
Member

@chrisdholt chrisdholt commented Jun 30, 2020

Description

This PR updates typescript and utility-types dependencies to leverage the latest major version across the repo.

Motivation & context

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@chrisdholt chrisdholt force-pushed the users/chhol/update-utility-types-versions-to-3.7 branch from e0e8d5d to d1e4b2a Compare June 30, 2020 23:35
@@ -112,7 +112,6 @@
"ts-jest": "^25.4.0",
"ts-loader": "^4.0.1",
"typescript": "3.3.3",
"utility-types": "^2.1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think utility-types is needed now that we've updated TypeScript. I think we can simply remove it.

Copy link
Contributor

@EisenbergEffect EisenbergEffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending the actual need for utility-types. I looked over that package and see a number of types that have been added directly to TypeScript. So, if we are using only those types that have been added, I would recommend removing the dependency. Less dependencies === better 😄

@chrisdholt chrisdholt force-pushed the users/chhol/update-utility-types-versions-to-3.7 branch from 9476355 to 34200fe Compare July 2, 2020 00:08
@chrisdholt chrisdholt changed the title fix: update utility types dependencies for react packages feat: update typescript version and update utility types dependencies for react packages Jul 2, 2020
@nicholasrice nicholasrice changed the title feat: update typescript version and update utility types dependencies for react packages feat: update typescript version and remove utility types dependencies for react packages Jul 2, 2020
@chrisdholt
Copy link
Member Author

Approved pending the actual need for utility-types. I looked over that package and see a number of types that have been added directly to TypeScript. So, if we are using only those types that have been added, I would recommend removing the dependency. Less dependencies === better 😄

We decided to update Typescript and do what we can to drop :)


typescript@^3.7.5, typescript@~3.7.2:
typescript@~3.7.2:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost had it.

@chrisdholt chrisdholt force-pushed the users/chhol/update-utility-types-versions-to-3.7 branch from b6d0c51 to 8af4350 Compare July 2, 2020 17:25
@chrisdholt chrisdholt force-pushed the users/chhol/update-utility-types-versions-to-3.7 branch from 8f12d1c to 70e84f2 Compare July 2, 2020 23:33
@chrisdholt chrisdholt merged commit 09d07b5 into master Jul 3, 2020
@chrisdholt chrisdholt deleted the users/chhol/update-utility-types-versions-to-3.7 branch July 3, 2020 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants