-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update typescript version and remove utility types dependencies for react packages #3422
feat: update typescript version and remove utility types dependencies for react packages #3422
Conversation
e0e8d5d
to
d1e4b2a
Compare
@@ -112,7 +112,6 @@ | |||
"ts-jest": "^25.4.0", | |||
"ts-loader": "^4.0.1", | |||
"typescript": "3.3.3", | |||
"utility-types": "^2.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think utility-types is needed now that we've updated TypeScript. I think we can simply remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending the actual need for utility-types
. I looked over that package and see a number of types that have been added directly to TypeScript. So, if we are using only those types that have been added, I would recommend removing the dependency. Less dependencies === better 😄
9476355
to
34200fe
Compare
We decided to update Typescript and do what we can to drop :) |
|
||
typescript@^3.7.5, typescript@~3.7.2: | ||
typescript@~3.7.2: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost had it.
b6d0c51
to
8af4350
Compare
8f12d1c
to
70e84f2
Compare
Description
This PR updates typescript and utility-types dependencies to leverage the latest major version across the repo.
Motivation & context
Issue type checklist
Is this a breaking change?
Adding or modifying component(s) in
@microsoft/fast-components
checklistProcess & policy checklist