Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: slider thumb does not respond to touch events, vertical sliders track parameters incorrect after scrolling page #3414

Merged
merged 5 commits into from
Jul 1, 2020
Merged

fix: slider thumb does not respond to touch events, vertical sliders track parameters incorrect after scrolling page #3414

merged 5 commits into from
Jul 1, 2020

Conversation

marjonlynch
Copy link
Contributor

@marjonlynch marjonlynch commented Jun 30, 2020 •
edited
Loading

Description

  • added touch related events for dragging the slider thumb on mobile devices
  • issue fixed when the vertical slider was further down the page scrolling could cause the track min and max to be incorrect.

Screen Shot 2020-06-30 at 3 08 59 PM

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@marjonlynch marjonlynch self-assigned this Jun 30, 2020
@marjonlynch marjonlynch force-pushed the users/marjon/slider-touch-fix branch from a2f8025 to 88d7cac Compare June 30, 2020 21:59
@marjonlynch marjonlynch force-pushed the users/marjon/slider-touch-fix branch from 133e346 to 62859a5 Compare June 30, 2020 23:32
@marjonlynch marjonlynch force-pushed the users/marjon/slider-touch-fix branch from 62859a5 to be5079f Compare July 1, 2020 16:09
@marjonlynch marjonlynch merged commit 02f9ac4 into master Jul 1, 2020
@marjonlynch marjonlynch deleted the users/marjon/slider-touch-fix branch July 1, 2020 16:33
@chrisdholt chrisdholt mentioned this pull request Jul 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scomea scomea scomea left review comments

@janechu janechu janechu approved these changes

@nicholasrice nicholasrice nicholasrice approved these changes

@EisenbergEffect EisenbergEffect EisenbergEffect approved these changes

@chrisdholt chrisdholt Awaiting requested review from chrisdholt

@awentzel awentzel Awaiting requested review from awentzel

@Falkicon Falkicon Awaiting requested review from Falkicon

Assignees

@marjonlynch marjonlynch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marjonlynch @EisenbergEffect @nicholasrice @janechu @scomea