Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add a placeholder to the fast-text-field example in fast component explorer #3413

Merged
merged 1 commit into from
Jun 29, 2020
Merged

fix: add a placeholder to the fast-text-field example in fast component explorer #3413

merged 1 commit into from
Jun 29, 2020

Conversation

khamudom
Copy link
Contributor

@khamudom khamudom commented Jun 29, 2020 •
edited
Loading

Description

Update the example for text-field by adding a placeholder.

before
image

after
image

Motivation & context

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@khamudom khamudom requested a review from janechu June 29, 2020 20:17
@khamudom khamudom requested a review from nicholasrice as a code owner June 29, 2020 20:17
@khamudom khamudom self-assigned this Jun 29, 2020
@khamudom khamudom requested a review from chrisdholt June 29, 2020 20:19
@khamudom khamudom force-pushed the users/khamu/text-field-placeholder branch from 65deba9 to 66a1795 Compare June 29, 2020 20:25
@khamudom khamudom merged commit 9c4bb72 into master Jun 29, 2020
@khamudom khamudom deleted the users/khamu/text-field-placeholder branch June 29, 2020 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janechu janechu janechu approved these changes

@awentzel awentzel awentzel approved these changes

@nicholasrice nicholasrice Awaiting requested review from nicholasrice

@chrisdholt chrisdholt Awaiting requested review from chrisdholt

Assignees

@khamudom khamudom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khamudom @janechu @awentzel