Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adds tsdoc comments to fast-components-msft #3332

Merged
merged 7 commits into from
Jun 18, 2020
Merged

chore: adds tsdoc comments to fast-components-msft #3332

merged 7 commits into from
Jun 18, 2020

Conversation

nicholasrice
Copy link
Contributor

@nicholasrice nicholasrice commented Jun 17, 2020 •
edited
Loading

Description

Adds tsdoc comments for all exports of fast-components-msft. Also integrates the doc process into CI.

Motivation & context

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

chrisdholt
chrisdholt approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@chrisdholt chrisdholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good

@EisenbergEffect EisenbergEffect mentioned this pull request Jun 18, 2020
Closed
35 tasks
EisenbergEffect
EisenbergEffect approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@EisenbergEffect EisenbergEffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick skim of this and looks good.

@nicholasrice nicholasrice merged commit 8050a3d into master Jun 18, 2020
@nicholasrice nicholasrice deleted the users/nirice/document-fast-components-msft branch June 18, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdholt chrisdholt chrisdholt approved these changes

@EisenbergEffect EisenbergEffect EisenbergEffect approved these changes

@awentzel awentzel Awaiting requested review from awentzel

@Falkicon Falkicon Awaiting requested review from Falkicon

@janechu janechu Awaiting requested review from janechu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicholasrice @EisenbergEffect @chrisdholt