fix: update progress from accent fill to accent foreground #3277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bheston
requested review from
chrisdholt,
janechu and
nicholasrice
as code owners
packages/web-components/fast-components-msft/src/progress/progress/progress.styles.ts
Show resolved
Hide resolved
bheston
force-pushed
the
users/bheston/fix-progress-accent-foreground
branch
from
bb94268
to
5a32511
Compare
chrisdholt
approved these changes
Jun 11, 2020
EisenbergEffect
approved these changes
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated progress from accent fill to accent foreground.
Motivation & context
In dark mode the wrong accent color was used, resulting in low contrast and failing accessibility tests.
Issue type checklist
Is this a breaking change?
Adding or modifying component(s) in
@microsoft/fast-componentschecklistProcess & policy checklist