Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: corrects behavior of style removal #3261

Merged
merged 7 commits into from
Jun 10, 2020
Merged

fix: corrects behavior of style removal #3261

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5bdfab0
fix style removal behavior
nicholasrice Jun 9, 2020
c1ddd3c
Merge branch 'master' into users/nirice/fix-style-removal-behavior
nicholasrice Jun 9, 2020
7e46a2c
adding tests
nicholasrice Jun 10, 2020
84458f2
Merge branch 'master' into users/nirice/fix-style-removal-behavior
nicholasrice Jun 10, 2020
b40ea34
limit exports from package root
nicholasrice Jun 10, 2020
071ae55
Merge branch 'master' into users/nirice/fix-style-removal-behavior
nicholasrice Jun 10, 2020
a9b732d
Merge branch 'master' into users/nirice/fix-style-removal-behavior
EisenbergEffect Jun 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/web-components/fast-element/src/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ class AdoptedStyleSheetsStyles extends ElementStyles {
public removeStylesFrom(target: StyleTarget): void {
const sourceSheets = this.styleSheets;
target.adoptedStyleSheets = target.adoptedStyleSheets!.filter(
(x: CSSStyleSheet) => sourceSheets.indexOf(x) !== -1
(x: CSSStyleSheet) => sourceSheets.indexOf(x) === -1
);
}
}
Expand Down