chore: update root readme language #3195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdholt
requested review from
awentzel,
EisenbergEffect and
Falkicon
as code owners
chrisdholt
force-pushed
the
users/chhol/update-root-readme-documentation
branch
from
a186413 to
c1ca345
Compare
EisenbergEffect
approved these changes
May 28, 2020
awentzel
approved these changes
May 28, 2020
| @@ -24,15 +24,15 @@ There are a million and one great ways to build your next website or application | |||
| This principle of being unopinionated manifests in several important ways including: | |||
|
|
|||
| * A flat component architecture that lets you compose what you need without struggling with rigid patterns and complex objects. | |||
| * Separating base components and style that supports multiple frameworks without re-writing or duplicating styles. This separation also lets you build your own styles, with your styling technology of choice, without having to re-build or duplicate the base components. | |||
| * Separating base components from styles and design systems to support multiple implementations without re-writing or duplicating styles. Use the design system to customize existing styled components, or build your own styles, with your design system, without having to re-build or duplicate the base components. | |||
There was a problem hiding this comment.
Suggested change
| * Separating base components from styles and design systems to support multiple implementations without re-writing or duplicating styles. Use the design system to customize existing styled components, or build your own styles, with your design system, without having to re-build or duplicate the base components. | |
| * Separating base components from styles and design systems to support multiple implementations without re-writing or duplicating styles. Use the design system to customize existing styled components, or build your own styles with your design system, without having to re-build or duplicate the base components. |
There was a problem hiding this comment.
The above comma seems un-necessary but disregard if you disagree.
There was a problem hiding this comment.
@EisenbergEffect I merge this in so it could go with the other doc work being done over the weekend. If Chris didn't get a chance to resolve this we can do it in a future PR. I presume we'll be doing a wide edit session on all of this documentation in the future as well.
There was a problem hiding this comment.
I didn’t see this, but we certainly should do a scrub in the future. For now I’d agree that the most important thing is accurate content. Thx for merging Aaron!
nicholasrice
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the language in the root readme to better represent the current offerings of FAST-DNA.
Issue type checklist
Is this a breaking change?
Process & policy checklist