feat: add fast-foundation as a new package #3122

chrisdholt · 2020-05-13T22:11:49Z

Description

This PR adds fast-foundation as a new package. This package includes the templates, classes, and common utilities used to compose fast web components.

Issue type checklist

Chore: A change that does not impact distributed packages.
Bug fix: A change that fixes an issue, link to the issue above.
New feature: A change that adds functionality.

Is this a breaking change?

This change causes current functionality to break.

Process & policy checklist

I have added tests for my changes.
I have tested my changes.
I have updated the project documentation to reflect my changes.
I have read the CONTRIBUTING documentation and followed the standards for this project.

janechu · 2020-05-13T22:19:31Z

I believe this should be marked as a breaking change.

EisenbergEffect

I definitely think this is the right way to go. Thanks @chrisdholt, especially for adding the usage docs. Nice touch.

One teeny, weeny, very annoying request have to make....can we add the .js file extension to all the imports? I can do it myself when I fix up the builds, but I'd prefer to have only one PR that touches all the files as opposed to two if possible.

chrisdholt · 2020-05-13T22:30:28Z

I definitely think this is the right way to go. Thanks @chrisdholt, especially for adding the usage docs. Nice touch.

One teeny, weeny, very annoying request have to make....can we add the .js file extension to all the imports? I can do it myself when I fix up the builds, but I'd prefer to have only one PR that touches all the files as opposed to two if possible.

We're having an issue with storybook for some reason handling the .js extensions. I'll start by adding it to the foundation package for sure :). We're going to need to work to solve it for the fast-components package though.

chrisdholt · 2020-05-13T22:41:22Z

packages/web-components/fast-foundation/src/design-system-provider/design-system-provider.ts

@@ -416,7 +416,7 @@ export class DesignSystemProvider extends FASTElement
 /**
 * Defines a design-system-provider custom element
 */
-export function designSystemProvider(name: string) {
+export function designSystemProvider(name: string, styles: ElementStyles | undefined) {


@nicholasrice and @EisenbergEffect want to bring attention to this API change as part of this. Because we aren't passing styles I needed to add that as part of the decorator here for composing the custom element.

Do we need to pass the template here also?

@EisenbergEffect and I discussed potentially opening this up to have the same API as @customElement - this might be the right time to make that change.

In that case, I think we should do that. I'll update.

janechu · 2020-05-13T22:48:06Z

packages/web-components/fast-foundation/README.md

@@ -0,0 +1,2 @@
+# FAST Foundation
+A suite of templates, classes, and utilities for composing web components.


Can we make a note that this should be fleshed out like our other README files to show installation and basic use?

Yeah I wanted to get feedback on what all we want to outline in here.

packages/web-components/fast-components/package.json

packages/web-components/fast-foundation/src/storybook-typings.d.ts

eljefe223 · 2020-05-13T23:11:42Z

smoked fast-components works

janechu · 2020-05-14T00:33:39Z

packages/web-components/fast-foundation/src/badge/README.md

+    template,
+    styles,
+})
+export class FASTBadge extends Badge {}


just a note that we probably need to expand on badge with the inclusion of css variables (not necessarily in this PR but without that the usage is incomplete).

nicholasrice · 2020-05-14T01:09:04Z

packages/web-components/fast-components/src/index.ts

@@ -3,14 +3,13 @@ export * from "./badge";
 export * from "./button";
 export * from "./card";
 export * from "./checkbox";
-export * from "./custom-properties";
+export * from "./color";


you'll need to export the recipe behaviors from "./styles/recipes".

If we don't need the color recipes exported right now I would hold off

* add initial frame for fast-foundation * move specs from fast-components to fast-foundation * remove dupe templates and classes from fast-components * update pathing to reference fast-foundation * update package.json package title * remove reference to fast slider * update pathing for components and revert unintentional file removal * update readme paths to specs * drop errant inclusion of changelog * update design system provider readmes * fix focus styling on anchor and button * remove unnecessary slider-util file from fast-components * remove unnecessary references to storybook * update designSystemProvider decorator API to expect template * fix eslint error on import order * fix readme capitalization * drop dependency on fast-web-utilities * update design system provider readme to reflect api * export color recipes * export color recipes * remove unused vars * update pathing to .js * add initial package.json version BREAKING CHANGE

BREAKING CHANGE * add initial frame for fast-foundation * move specs from fast-components to fast-foundation * remove dupe templates and classes from fast-components * update pathing to reference fast-foundation * update package.json package title * remove reference to fast slider * update pathing for components and revert unintentional file removal * update readme paths to specs * drop errant inclusion of changelog * update design system provider readmes * fix focus styling on anchor and button * remove unnecessary slider-util file from fast-components * remove unnecessary references to storybook * update designSystemProvider decorator API to expect template * fix eslint error on import order * fix readme capitalization * drop dependency on fast-web-utilities * update design system provider readme to reflect api * export color recipes * export color recipes * remove unused vars * update pathing to .js * add initial package.json version BREAKING CHANGE

* add initial frame for fast-foundation * move specs from fast-components to fast-foundation * remove dupe templates and classes from fast-components * update pathing to reference fast-foundation * update package.json package title * remove reference to fast slider * update pathing for components and revert unintentional file removal * update readme paths to specs * drop errant inclusion of changelog * update design system provider readmes * fix focus styling on anchor and button * remove unnecessary slider-util file from fast-components * remove unnecessary references to storybook * update designSystemProvider decorator API to expect template * fix eslint error on import order * fix readme capitalization * drop dependency on fast-web-utilities * update design system provider readme to reflect api * export color recipes * export color recipes * remove unused vars * update pathing to .js * add initial package.json version Breaking Change

BREAKING CHANGE

BREAKING CHANGE: fundamental changes to the API and exports of certain packages

* add initial frame for fast-foundation * move specs from fast-components to fast-foundation * remove dupe templates and classes from fast-components * update pathing to reference fast-foundation * update package.json package title * remove reference to fast slider * update pathing for components and revert unintentional file removal * update readme paths to specs * drop errant inclusion of changelog * update design system provider readmes * fix focus styling on anchor and button * remove unnecessary slider-util file from fast-components * remove unnecessary references to storybook * update designSystemProvider decorator API to expect template * fix eslint error on import order * fix readme capitalization * drop dependency on fast-web-utilities * update design system provider readme to reflect api * export color recipes * export color recipes * remove unused vars * update pathing to .js * add initial package.json version BREAKING CHANGE: breaks certain package exports

chrisdholt requested review from awentzel, EisenbergEffect, Falkicon, janechu and nicholasrice as code owners May 13, 2020 22:11

chrisdholt self-assigned this May 13, 2020

chrisdholt added the breaking change 💥 label May 13, 2020

EisenbergEffect approved these changes May 13, 2020

View reviewed changes

chrisdholt commented May 13, 2020

View reviewed changes

janechu reviewed May 13, 2020

View reviewed changes

eljefe223 approved these changes May 13, 2020

View reviewed changes

chrisdholt mentioned this pull request May 13, 2020

fix: set slider thumb offset against its left position in the document #3125

Merged

8 tasks

chrisdholt force-pushed the users/chhol/add-fast-foundation-package branch from 744d635 to c883525 Compare May 14, 2020 00:14

nicholasrice approved these changes May 14, 2020

View reviewed changes

janechu approved these changes May 14, 2020

View reviewed changes

chrisdholt force-pushed the users/chhol/add-fast-foundation-package branch from c883525 to 6e7f3db Compare May 14, 2020 00:47

nicholasrice reviewed May 14, 2020

View reviewed changes

chrisdholt force-pushed the users/chhol/add-fast-foundation-package branch from fb05bb5 to 1e46a59 Compare May 14, 2020 02:40

chrisdholt mentioned this pull request May 14, 2020

[Intent to implement] Change default styles for fast-components and create a new MSFT package #3088

Closed

chrisdholt added 8 commits May 13, 2020 20:05

add initial frame for fast-foundation

6f04c94

move specs from fast-components to fast-foundation

c8dbade

remove dupe templates and classes from fast-components

68b0960

update pathing to reference fast-foundation

64327fa

update package.json package title

1ead8ca

remove reference to fast slider

4f0c1ff

update pathing for components and revert unintentional file removal

43a0b9f

update readme paths to specs

813334a

chrisdholt added 15 commits May 13, 2020 20:05

drop errant inclusion of changelog

171511f

update design system provider readmes

6ac1686

fix focus styling on anchor and button

6483705

remove unnecessary slider-util file from fast-components

b1eaacd

remove unnecessary references to storybook

a78a12c

update designSystemProvider decorator API to expect template

51ed5e4

fix eslint error on import order

2607481

fix readme capitalization

115aaf9

drop dependency on fast-web-utilities

3628252

update design system provider readme to reflect api

2f4103c

export color recipes

3d157b3

export color recipes

0c67dd9

remove unused vars

513b293

update pathing to .js

bc5e090

add initial package.json version

aad1697

chrisdholt force-pushed the users/chhol/add-fast-foundation-package branch from 1e46a59 to aad1697 Compare May 14, 2020 03:05

chrisdholt merged commit 208ae8a into master May 14, 2020

chrisdholt deleted the users/chhol/add-fast-foundation-package branch May 14, 2020 03:37

chrisdholt added a commit that referenced this pull request May 18, 2020

feat: add fast-foundation as a new package (#3122)

765cc55

BREAKING CHANGE

chrisdholt added a commit that referenced this pull request May 18, 2020

feat: add fast-foundation as a new package (#3122)

2808aaf

BREAKING CHANGE

chrisdholt added a commit that referenced this pull request May 18, 2020

feat: add fast-foundation as a new package (#3122)

f2245fa

BREAKING CHANGE: fundamental changes to the API and exports of certain packages

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add fast-foundation as a new package #3122

feat: add fast-foundation as a new package #3122

chrisdholt commented May 13, 2020 •

edited

Loading

janechu commented May 13, 2020

EisenbergEffect left a comment

chrisdholt commented May 13, 2020

chrisdholt May 13, 2020

nicholasrice May 13, 2020 •

edited

Loading

chrisdholt May 13, 2020

chrisdholt May 14, 2020

janechu May 13, 2020

chrisdholt May 13, 2020

eljefe223 commented May 13, 2020

janechu May 14, 2020

nicholasrice May 14, 2020

		@@ -0,0 +1,2 @@
		# FAST Foundation
		A suite of templates, classes, and utilities for composing web components.

feat: add fast-foundation as a new package #3122

feat: add fast-foundation as a new package #3122

Conversation

chrisdholt commented May 13, 2020 • edited Loading

Description

Issue type checklist

Process & policy checklist

janechu commented May 13, 2020

EisenbergEffect left a comment

Choose a reason for hiding this comment

chrisdholt commented May 13, 2020

chrisdholt May 13, 2020

Choose a reason for hiding this comment

nicholasrice May 13, 2020 • edited Loading

Choose a reason for hiding this comment

chrisdholt May 13, 2020

Choose a reason for hiding this comment

chrisdholt May 14, 2020

Choose a reason for hiding this comment

janechu May 13, 2020

Choose a reason for hiding this comment

chrisdholt May 13, 2020

Choose a reason for hiding this comment

eljefe223 commented May 13, 2020

janechu May 14, 2020

Choose a reason for hiding this comment

nicholasrice May 14, 2020

Choose a reason for hiding this comment

chrisdholt commented May 13, 2020 •

edited

Loading

nicholasrice May 13, 2020 •

edited

Loading