feat: add vertical and horizontal orientation for radio-group #3082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marjonlynch
requested review from
chrisdholt,
EisenbergEffect,
janechu and
nicholasrice
as code owners
marjonlynch
force-pushed
the
users/marjon/radio-add-orientation
branch
from
b245d99 to
1bd354e
Compare
chrisdholt
reviewed
May 7, 2020
packages/web-components/fast-components/src/radio-group/radio-group.template.ts
Outdated
Show resolved
Hide resolved
janechu
reviewed
May 7, 2020
packages/web-components/fast-components/src/radio-group/radio-group.ts
Outdated
Show resolved
Hide resolved
packages/web-components/fast-components/src/radio-group/fixtures/base.html
Outdated
Show resolved
Hide resolved
EisenbergEffect
suggested changes
May 8, 2020
packages/web-components/fast-components/src/radio-group/radio-group.ts
Outdated
Show resolved
Hide resolved
packages/web-components/fast-components/src/radio-group/radio-group.styles.ts
Show resolved
Hide resolved
janechu
approved these changes
May 8, 2020
chrisdholt
requested changes
May 8, 2020
There was a problem hiding this comment.
I love seeing the simplicity here. I’m going to hold on approving this only because I think it’s important to get perspective from @nicholasrice as it was a conversation with him on discord which led to the proposal tracking this. As long as we reach consensus to implement this, I’m good with this. I do want to be sure we give time for his feedback here.
nicholasrice
approved these changes
May 8, 2020
chrisdholt
approved these changes
May 8, 2020
marjonlynch
force-pushed
the
users/marjon/radio-add-orientation
branch
2 times, most recently
from
b720d03 to
3ca42e5
Compare
EisenbergEffect
approved these changes
May 11, 2020
marjonlynch
force-pushed
the
users/marjon/radio-add-orientation
branch
from
3ca42e5 to
df66712
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In response to #3069 adding the orientation attribute to fast-radio-group to allow for vertical orientation and a default of horizontal.
Motivation & context
Motivation described in proposal #3069.
Issue type checklist
Is this a breaking change?
Process & policy checklist