fix: replace color picker in figma plugin #3048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Standardizes the color-picker control so we don't have differences and bugs stemming from native implementations of the color picker.
Motivation & context
The color-picker shipped by OSX likes to send 100s of events per second while the user is dragging around the color-wheel. This requires a whole host of issues to fix, including debouncing the event, maintaining an un-denounced state so the picker doesn't feel laggy, and reconciling the two when the user stops interacting.
Issue type checklist
Is this a breaking change?
Process & policy checklist