Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds match-media stylesheet behavior #3016

Merged
merged 9 commits into from
Apr 27, 2020

Conversation

nicholasrice
Copy link
Contributor

@nicholasrice nicholasrice commented Apr 25, 2020

Description

Adds a behavior factory to conditionally add and remove stylesheets based on the matching of a media query. Also adds a forced-colors behavior implementation of this to conditionally apply high-contrast styles to components.

Motivation & context

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Copy link
Contributor

@EisenbergEffect EisenbergEffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incredibly awesome. ❤️

@nicholasrice nicholasrice force-pushed the users/nirice/high-contrast-behavior branch from bd6f3ea to 4e9560b Compare April 27, 2020 17:54
@nicholasrice nicholasrice force-pushed the users/nirice/high-contrast-behavior branch from 336b810 to 6f7f73b Compare April 27, 2020 18:33
@nicholasrice nicholasrice merged commit 650efc3 into master Apr 27, 2020
@nicholasrice nicholasrice deleted the users/nirice/high-contrast-behavior branch April 27, 2020 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants